[release/10.0] Fix notarization retry logging errors on intermediate attempts#17090
Merged
Merged
Conversation
Add maxAttempts parameter to RunMSBuild. RealSignTool implements retry logic internally: intermediate failures are logged as warnings instead of errors (which permanently mark the MSBuild task as failed), and only the final failure after all retries logs an error. The notarization call site passes maxAttempts=6. The signing call site uses the default (1), preserving existing behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LogWarning could be promoted to an error via MSBuildTreatAllWarningsAsErrors, defeating the retry fix. LogMessage with high importance is safe from promotion while still being visible in build output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/31915e9d-d3fe-4a84-a82d-f8008b1dfd7b Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>
…ressErrors parameter Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/3acedfec-93e1-4b0d-91fc-ad58d5531623 Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>
…rivate helper Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/33a477c6-abdb-4db2-8c35-a1fc909296d3 Co-authored-by: ViktorHofer <7412651+ViktorHofer@users.noreply.github.com>
Member
|
[automated] Cross-reference: this backport fixes a transient macOS notarization failure that is currently breaking CI downstream in microsoft/aspire#18715. Aspire builds on arcade |
Open
3 tasks
akoeplinger
approved these changes
Jul 14, 2026
akoeplinger
enabled auto-merge (squash)
July 14, 2026 18:45
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16669 to release/10.0
/cc @radical @ViktorHofer